Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typography style 'Segment Sub-header' line height issue #6335

Closed
1 task done
graham-blake opened this issue Sep 29, 2023 · 2 comments · Fixed by #7025
Closed
1 task done

Typography style 'Segment Sub-header' line height issue #6335

graham-blake opened this issue Sep 29, 2023 · 2 comments · Fixed by #7025
Labels
Bug On Backlog released typography

Comments

@graham-blake
Copy link

graham-blake commented Sep 29, 2023 •
edited
Loading

Current behaviour

The typography style 'Segment Sub-header' is 16px medium (700) weight text and has 31px line height. Is the line height an oversight or is there a particular reason for the 31px?
typography-segment-subheader-carbon

Expected behaviour

The Design System (via Figma) defines the line height to be 24px, which looks about right.
typography-segment-subheader-design-system

CodeSandbox or Storybook URL

https://carbon.sage.com/?path=/docs/typography--variants-story

JIRA Ticket (Sage Only)

No response

Suggested Solution

Note from Daniel Dipper in the Slack Carbon channel:

It looks like the line height value we have is the same value we were given in 2020 when Typography was first created. We followed these specs here. I believe all we require is an updated spec from the DS, so that we can update our component with the new values Typography requires.

Carbon Version

Latest

Design Tokens Version

N/A

What browsers are you seeing the problem on?

Chrome

What Operating System are you seeing the problem on?

MacOS

Anything else we should know?

I'm hoping this is an oversight but there may have been a specific reason for the 31px line-height in a particular case in a particular product.

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@graham-blake graham-blake added Bug triage Triage Required labels Sep 29, 2023
@robinzigmond
Copy link
Contributor

FE-6232

@robinzigmond robinzigmond added On Backlog and removed triage Triage Required labels Oct 3, 2023
nineteen88 added a commit that referenced this issue Oct 17, 2024
@nineteen88
feat(typography): update line heights to align with DS
1f894e1 
fix #6335
nineteen88 added a commit that referenced this issue Oct 17, 2024
@nineteen88
feat(typography): update line heights to align with DS
11b107e 
fix #6335
nineteen88 added a commit that referenced this issue Oct 18, 2024
@nineteen88
feat(typography): update line heights to align with DS
f7c1246 
fix #6335
@nineteen88 nineteen88 mentioned this issue Oct 18, 2024
Merged
14 tasks
carbonci pushed a commit that referenced this issue Oct 24, 2024
@semantic-release-bot @carbonci
chore(release): 144.1.0
e4bf21a 
## [144.1.0](v144.0.1...v144.1.0) (2024-10-24)

### Features

* **typography:** update line heights to align with DS ([fb6762f](fb6762f)), closes [#6335](#6335)
@carbonci
Copy link
Collaborator

🎉 This issue has been resolved in version 144.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug On Backlog released typography
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(typography): update line heights to align with DS Sage/carbon
4 participants
@robinzigmond @DipperTheDan @carbonci @graham-blake