Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typography): update line heights to align with DS #7025

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Conversation

nineteen88
Copy link
Contributor

Proposed behaviour

update all typography elements with the correct line heights as per the DS

fix #6335

Current behaviour

many line heights are incorrect/outdated

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

Typography styling values need to be cross referenced with the Design System to ensure they're correct

@edleeks87 edleeks87 marked this pull request as ready for review October 21, 2024 16:01
@edleeks87 edleeks87 requested review from a team as code owners October 21, 2024 16:01
@nineteen88 nineteen88 merged commit e43ee70 into master Oct 24, 2024
24 checks passed
@nineteen88 nineteen88 deleted the FE-6232 branch October 24, 2024 09:13
@carbonci
Copy link
Collaborator

🎉 This PR is included in version 144.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Typography style 'Segment Sub-header' line height issue
6 participants