chore: remove deprecated fieldset component #3013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit abd385d:
|
edleeks87
previously approved these changes
Jun 22, 2020
mkrds
previously approved these changes
Jun 22, 2020
|
Tested that the |
BREAKING CHANGE: The deprecated fieldset component has been removed. To upgrade please use the experimental fieldset component. Fixes FE-1921
jamime
force-pushed
the
remove_deprecated_fieldset
branch
from
46befc8 to
abd385d
Compare
mkrds
approved these changes
Jun 23, 2020
edleeks87
approved these changes
Jun 23, 2020
|
🎉 This PR is included in version 31.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
The deprecated fieldset component has been removed.
Current behaviour
We have a deprecated and experimental version.
Checklist
- [ ] Screenshots are included in the PR
- [ ] Carbon implementation and Design System documentation are congruent
- [ ] All themes are supported- [ ] Unit tests added or updated
- [ ] Cypress automation tests added or updated
- [ ] Storybook added or updated
- [ ] Typescriptd.tsfile added or updatedAdditional context
FE-1921
Testing instructions
Ensure that the
__deprecated__fieldset has been removed from storybook.All other fieldset components in storybook should still work.