Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: prevent credentials being stored from checkout #3014

Merged
merged 3 commits into from
Jun 23, 2020
Merged

Conversation

jamime
Copy link

@jamime jamime commented Jun 23, 2020

Proposed behaviour

Revert #3013 and #3012
Use persist-credentials: false so semantic-release uses the GH_TOKEN to push to the repo.

Current behaviour

semantic-release is using the checkout token that does not have push access.

Checklist

- [ ] Screenshots are included in the PR
- [ ] Carbon implementation and Design System documentation are congruent
- [ ] All themes are supported

  • Commits follow our style guide

- [ ] Unit tests added or updated
- [ ] Cypress automation tests added or updated
- [ ] Storybook added or updated
- [ ] Typescript d.ts file added or updated

Additional context

semantic-release/git#196

Testing instructions

Merge to master and check the semantic-release job.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 23, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6e89333:

Sandbox Source
affectionate-bose-qhmbm Configuration

chrisbarber86
chrisbarber86 previously approved these changes Jun 23, 2020
…tton"

This reverts commit 20c0eba, reversing
changes made to c83dc0e.
@jamime jamime merged commit c2146bb into master Jun 23, 2020
@jamime jamime deleted the semantic-release-fix branch June 23, 2020 10:27
@carbonci
Copy link
Collaborator

🎉 This PR is included in version 31.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants