feat: remove focusRedesignOptOut feature flag #7076
+394
−2,398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomdavies73
changed the title
There was a problem hiding this comment.
suggestion: You may be able to remove theme from line 156 as it looks like it isn't used elsewhere in the file.
| @@ -278,11 +268,7 @@ const StyledDayPicker = styled.div` | |||
| ${({ theme }) => | |||
There was a problem hiding this comment.
suggestion: It might be the same case here that we can remove the theme here. From a glance, I cannot see it being used, but I may be wrong, so please double-check 😄
Parsium
reviewed
Nov 18, 2024
There was a problem hiding this comment.
Great work on this @tomdavies73 👍🏼 I noticed a few unused theme variables in some parts of the code. Could you take a look and remove them?
To identity these, this command should help:
npx eslint ./src --rule "{ '@typescript-eslint/no-unused-vars': 'error' }" --quietThanks!
src/components/duelling-picklist/picklist-item/picklist-item.test.tsx
Outdated
Show resolved
Hide resolved
Parsium
previously approved these changes
Nov 19, 2024
DipperTheDan
previously approved these changes
Nov 19, 2024
tomdavies73
dismissed stale reviews from DipperTheDan and Parsium
via
0e5e02e
paulrobinson88
previously approved these changes
Nov 21, 2024
This update removes the `focusRedesignOptOut` feature flag, consumers can no longer opt out of the dual outline focus styling BREAKING CHANGE: The `focusRedesignOptOut` feature flag has been removed completely. If passed to the `CarbonProvider` it will need to be removed, if consumers are also relying on previous focus styling this will also no longer be available.
Parsium
approved these changes
Dec 18, 2024
DipperTheDan
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
This update removes the
focusRedesignOptOutfeature flag, consumers can no longer opt out of the dual outline focus stylingCurrent behaviour
Currently, consumers can opt out of the dual outline focus styling.
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions