Skip to content
This repository has been archived by the owner on Oct 6, 2021. It is now read-only.

Refactor injection site finder #12

Merged
merged 26 commits into from
Feb 18, 2020
Merged

Refactor injection site finder #12

merged 26 commits into from
Feb 18, 2020

Conversation

adamltyson
Copy link
Member

@adamltyson adamltyson added the enhancement New feature or request label Feb 4, 2020
@adamltyson adamltyson self-assigned this Feb 4, 2020
@adamltyson
Copy link
Member Author

@FedeClaudi When you get a minute, could you confirm that this refactored version still does what you expect?

So far done:

  • Remove dependency on amap (by moving functionality to imlib).
  • Remove dependency on vtkplotter by getting largest connected component using scikit-image.
  • Reduced amount of code by moving a lot of "standard" functions to imlib.
  • Allow logging to be onto to console (to file optional)
  • Format with black

Still to do:

  • Add tests (also in imlib)
  • Generalise to other pixel sizes, orientations etc
  • Remove hard-coded filenames (interface better with amap output directory/log file)
  • Add different segmentation strategies (manual, semi-automatic).

@adamltyson adamltyson merged commit 58d7838 into SainsburyWellcomeCentre:injectionsite Feb 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant