various SLAS adjustments, added callbackURIs #318
Conversation
| @@ -2062,11 +2064,12 @@ program | |||
| const secret = options.secret; | |||
| const channels = !options.channels || options.channels.split(',').map(item => item.trim()); | |||
| const scopes = !options.scopes || options.scopes.split(',').map(item => item.trim()); | |||
| const redirecturis = !options.redirecturis || options.redirecturis.split(',').map(item => item.trim()); | |||
| const redirecturis = options.redirecturis ? options.redirecturis.split(',').map(item => item.trim()) : []; | |||
There was a problem hiding this comment.
needs to be set to an empty array if the client does not have redirectURLs (passwordless login)
| @@ -120,7 +120,7 @@ const slas = { | |||
| handleCLIError('Could not get tenant: ', e.message, asJson) | |||
| } | |||
| }, | |||
| list: async (shortcode, tenantId, asJson) => { | |||
| list: async (tenantId, shortcode, asJson) => { | |||
There was a problem hiding this comment.
order from cli expects the reverse:
await slas.cli.client.list(options.tenant, options.shortcode, asJson);
sandragolden
force-pushed
the
bugfix/slas-updates
branch
from
52fe711
to
a301eb7
Compare
|
@tobiaslohr This should be ready to merge. I double checked all the commands via the command line as well as via the JS API and they all work without error with the exception of I don't think there are any breaking-changes here. I switched the order of the params on I see this is failing |
|
Thanks for your contribution @sandragolden! |
Mostly just fixing some minor typos in params, also added callback URIs needed for password resets and passwordless login
cc: @hnestmann