removing dependency node-fetch to alleviate snyk issues #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome @clavery, will have a look at this. |
|
@clavery Can you please review the PR again as the branch has some conflicts. |
|
@tobiaslohr all set @sandragolden FYI I think all your stuff is merged properly here |
tobiaslohr
approved these changes
Nov 16, 2022
|
Thanks @clavery for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
node-fetchfrom the project as we keep getting snyk PRs that we cannot address due to node-fetch moving to ESM-only.i.e. This should allow us to close #319 outright
This uses the existing
requestpackage and simply wraps it asynchronously so that the code flows largely the same without rewriting it in callback-style. Side-benefit here is that we get the same HTTP debug output as other commands.I incidentally fixed some (but not all) bugs also fixed in @sandragolden's PR #318 as that was necessary to test some of these commands but there's lots more updates in that PR.
cc @hnestmann