Basic user mgmt #47
Merged
Basic user mgmt #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tobiaslohr
commented
Jul 15, 2019
•
tobiaslohr
commented
- Exploring Account Manager orgs and users
- Management of Account Manager users incl. CRUD operations and grant/revoke of roles to/from users in Account Manager
- Management of Business Manager users incl. querying users, CRUD operations and grant/revoke of roles to/from users in Business Manager
…ogin <login> to read details of a single users
…index 0, default count is 25
…instance with role
tobiaslohr
requested review from
kdomachowski,
SGD1953,
hnestmann and
challmannsf
challmannsf
approved these changes
Jul 16, 2019
hnestmann
reviewed
Jul 16, 2019
| console.log(' Examples:'); | ||
| console.log(); | ||
| console.log(' $ sfcc-ci org:list') | ||
| console.log(' $ sfcc-ci org:list --org "my-org"') |
There was a problem hiding this comment.
shouldn't this be org:get?
There was a problem hiding this comment.
I was following an approach to read list(s) of objects, which optionally can be narrowed down to a single unique object, like
org:list,org:list --org <org>user:list,user:list --login <login>roles:list,role:list --role <role>
The only exception still is sandbox:list and sandbox:get, which I plan to merge into a sandbox:list --sandbox <sandbox>
There was a problem hiding this comment.
OK - I like the pattern, I was commenting for consistency.
I thought there are more getters, but since I work a lot with sandbox:get I was wrong.
So in summary we need three tickets
- Unit Tests Completion
- Documentation
- Refactor sandbox:get
| console.log(); | ||
| console.log(' $ sfcc-ci role:grant --login the-user --role the-role'); | ||
| console.log(' $ sfcc-ci role:grant --login the-user --role the-role --scope zzzz_dev'); | ||
| console.log(' $ sfcc-ci role:grant --login the-user --role the-role --scope zzzz_*'); |
This was referenced Jul 16, 2019
SGD1953
requested changes
Jul 16, 2019
|
@kdomachowski @SGD1953 @hnestmann can you re-review based on the latest changes please? thanks |
SGD1953
approved these changes
Jul 24, 2019
hnestmann
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.