NoParamTypeRemovalRule: Skip constructors (rectorphp#37)

* NoParamTypeRemovalRule: Skip constructors * Update SkipConstruct.php
SanderMuller · Jul 9, 2024 · 59124fe · 59124fe
1 parent 7a96f32
commit 59124fe
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 0 deletions.
diff --git a/src/Rules/NoParamTypeRemovalRule.php b/src/Rules/NoParamTypeRemovalRule.php
@@ -48,6 +48,10 @@ public function processNode(Node $node, Scope $scope): array
         }
 
         $classMethodName = (string) $node->name;
+        if ($classMethodName === '__construct') {
+            return [];
+        }
+
         $parentClassMethodReflection = $this->methodNodeAnalyser->matchFirstParentClassMethod($scope, $classMethodName);
         if (! $parentClassMethodReflection instanceof PhpMethodReflection) {
             return [];

diff --git a/tests/Rules/NoParamTypeRemovalRule/Fixture/SkipConstruct.php b/tests/Rules/NoParamTypeRemovalRule/Fixture/SkipConstruct.php
@@ -0,0 +1,20 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\TypePerfect\Tests\Rules\NoParamTypeRemovalRule\Fixture;
+
+class SkipConstruct extends ParentConstructorClass
+{
+    public function __construct($someArg, $someOther)
+    {
+        parent::__construct('foo', 4);
+    }
+}
+
+class ParentConstructorClass
+{
+    public function __construct(string $string, int $int)
+    {
+    }
+}
diff --git a/tests/Rules/NoParamTypeRemovalRule/NoParamTypeRemovalRuleTest.php b/tests/Rules/NoParamTypeRemovalRule/NoParamTypeRemovalRuleTest.php
@@ -23,6 +23,7 @@ public function testRule(string $filePath, array $expectedErrorMessagesWithLines
 
     public static function provideData(): Iterator
     {
+        yield [__DIR__ . '/Fixture/SkipConstruct.php', []];
         yield [__DIR__ . '/Fixture/SkipPhpDocType.php', []];
         yield [__DIR__ . '/Fixture/SkipPresentType.php', []];
         yield [__DIR__ . '/Fixture/SkipNoType.php', []];