Remove LICENSE and README meta in .gitignore #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: LICENSE.meta and README.md.meta file is not included in the UniVRMShaders UPM package registory. So, “Read only asset Packages/com.vrmc.vrmshaders/MToon/LICENSE has not meta file.” error in imported project. After: real .meta files exists, so remove it from .gitignore file will also include the .meta when publish to UPM package registory. And should not affect imports by git-url.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
変更前
LICENSE.meta と README.md.meta ファイルは存在しますが、.gitignoreの記述によってUniVRMShadersのUPMパッケージからは除外されます。
そのため、UniVRMShadersのUPMをレジストリからインポートしたプロジェクトでは次のエラーが出ます。
変更後
.gitignoreから.metaの記述を削除することにより、UPMレジストリにpublishするときに LICENSE.meta と README.md.meta ファイルも含まれるようになり、上記エラーは出なくなります。
また、Git URLによるインポートでは従来から LICENSE.meta と README.md.meta ファイルは含まれているため、インポート後の状態に変化はありません。