Add id to the generated plot. #2098 #2099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good as a bug fix |
lucas-wilkins
approved these changes
Jun 20, 2022
|
I can confirm the fix works on Mac. Ready to nerge. |
|
Confirm the fix also works on W10/x64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plots generated by the Data Operation tool did not have the
idattribute set. This attribute is used as a dict key when saving plots to the project json file.Added the id attribute.
A more correct way would be to have this (and other, required) attributes defaulted in the Plotter initializer, so they are always present. This should be a part of the plot rewrite story, mentioned elsewhere