Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release 5.0.6] Master 5.0.6 release PR #2407

Merged
merged 39 commits into from
Jan 27, 2023
Merged

[Release 5.0.6] Master 5.0.6 release PR #2407

merged 39 commits into from
Jan 27, 2023

Conversation

krzywon
Copy link
Contributor

@krzywon krzywon commented Dec 19, 2022

@rozyczko rozyczko marked this pull request as draft December 20, 2022 14:47
rozyczko and others added 12 commits December 22, 2022 17:54
@rozyczko
Force maximize and be careful about the order of instantiation, so the
9e1eed0 
fitting widget shows properly. #2272
@rozyczko
Set min width on squishable elements
5129367
@rozyczko
fix references to 'config'
28f6051
@krzywon @rozyczko
Close the bumps convergence (results) panel when data is deleted
b050585
@krzywon @rozyczko
Pass data object to result panel to limit imports
ac00a94
@krzywon @rozyczko
Change dataDeleted to onDataDeleted for semantic reasons, and remove …
60206ec 
…data from results panel when data deleted
@lucas-wilkins
Fix for plotting not updating
340459b
@lucas-wilkins @caitwolf
Fix for plotting not updating
1126ac8 
Co-Authored-By: caitwolf <caitmwolf@gmail.com>
@caitwolf
Fixed bug in smearing implementation of sesans data that was passing …
2d1ca12 
…x data in correlation space to the calculator which requires x data in q space
@caitwolf
minor text changes in comment for clarity
eb213fe
@caitwolf
fixed bug that was swtiching the Use dQ Data slit length and width
c42a7df
@caitwolf
fixed sesans residuals plots to show in real space rather than q space
e7adcde
@krzywon krzywon changed the title [Release 5.0.6] Various plotting fixes [Release 5.0.6] Master 5.0.6 release PR Jan 10, 2023
@caitwolf
Copy link
Contributor

caitwolf commented Jan 10, 2023 •
edited
Loading

I added cherry-picks for the following PRs as part of the 5.0.6 release, many of these are SESANS related:

butlerpd and others added 7 commits January 23, 2023 00:35
@butlerpd
up default points on slicer and fix a few related slicer bugs
dfd0208 
the slicers defaulted to 20 or 36 points (depending on the slicer). This is almost never a reasonable number and there have been several request for that to be made larger. Upped it to 100 here.

Noted in testing that the box slicer validators were not properly checking for 0 points (the other slicers did) . In fact they were do nothing functions so fixed that by adding the appropriate code snipet.

Also all the slicers seemed to have the default set in a couple of different places which caused some odd behavior in at least on case. that was cleaned up as well.
@butlerpd
Change polydispersity plot to linear linear
2e79d6b
@rozyczko @butlerpd
Enable plot redraw on linear/log scale change
557acbf 
Modified initial state to be log scale
@butlerpd
Change defaults for theory plot.
1b1e80c 
from 50 to 150 points and default to log spacing of data
@butlerpd
Fix issue with residual y scaling called twice. Keep it in the residu…
f75521b 
…als creation and delete from residuals plotting
@butlerpd
Cleaned up incorrect comment lines after review
e8f6431
@butlerpd
Merge branch 'release_5.0.6_plotting_fixes' of https://github.com/Sas…
a86a3ed 
…View/sasview into release_5.0.6_plotting_fixes
@wpotrzebowski
Copy link
Contributor

I haven't tested this version extensively but copying parameters to LATEX and Excel doesn't seem to work:
15:22:07 - ERROR: Traceback (most recent call last): File "sas/qtgui/Perspectives/Fitting/FittingPerspective.py", line 123, in onLatexCopy File "sas/qtgui/Perspectives/Fitting/FittingWidget.py", line 3896, in onCopyToClipboard File "sas/qtgui/Perspectives/Fitting/FittingUtilities.py", line 863, in formatParametersLatex IndexError: list index out of range

@krzywon
Copy link
Contributor Author

krzywon commented Jan 23, 2023

I haven't tested this version extensively but copying parameters to LATEX and Excel doesn't seem to work: 15:22:07 - ERROR: Traceback (most recent call last): File "sas/qtgui/Perspectives/Fitting/FittingPerspective.py", line 123, in onLatexCopy File "sas/qtgui/Perspectives/Fitting/FittingWidget.py", line 3896, in onCopyToClipboard File "sas/qtgui/Perspectives/Fitting/FittingUtilities.py", line 863, in formatParametersLatex IndexError: list index out of range

@wpotrzebowski - #2369, opened by @smk, seems to be a similar, if not the same, issue.

@wpotrzebowski
Copy link
Contributor

I haven't tested this version extensively but copying parameters to LATEX and Excel doesn't seem to work: 15:22:07 - ERROR: Traceback (most recent call last): File "sas/qtgui/Perspectives/Fitting/FittingPerspective.py", line 123, in onLatexCopy File "sas/qtgui/Perspectives/Fitting/FittingWidget.py", line 3896, in onCopyToClipboard File "sas/qtgui/Perspectives/Fitting/FittingUtilities.py", line 863, in formatParametersLatex IndexError: list index out of range

@wpotrzebowski - #2369, opened by @smk, seems to be a similar, if not the same, issue.

Thanks @krzywon for pointing this out. In my case it didn't work with core shell model. I need to check if it is model dependent and more importantly in the context of 5.0.6 is it also a bug in 5.0.5.

@krzywon
Copy link
Contributor Author

krzywon commented Jan 27, 2023 •
edited
Loading

Thanks @krzywon for pointing this out. In my case it didn't work with core shell model. I need to check if it is model dependent and more importantly in the context of 5.0.6 is it also a bug in 5.0.5.

The second comment in the ticket mentions it applies to all multiplicity models, not just unified_power_rg. I'm updating the title now for clarity.

Edited to correct: the second comment suggests it applies to them, but I've tested and the error is thrown on the n/shells/layers/etc. parameter.

llimeht and others added 2 commits January 27, 2023 15:45
@llimeht @krzywon
Fix incorrect escape sequences
405f51e 
Embedded latex ends up with lots of backslashes that need to be protected as
raw strings rather than (mis)interpreted as standard C-style escape sequences.
@krzywon
Merge branch 'release_5.0.6' into release_5.0.6_plotting_fixes
099067d
@krzywon krzywon marked this pull request as ready for review January 27, 2023 20:52
butlerpd
butlerpd approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@butlerpd butlerpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR just cherry picks a number of agreed upon commits to main which were already tested and code reviewed. Thus I think we should approve the merge and test the release branch as a whole to make sure none of these are relying on changes not picked.

@butlerpd butlerpd merged commit c8ac08f into release_5.0.6 Jan 27, 2023
@krzywon krzywon deleted the release_5.0.6_plotting_fixes branch January 27, 2023 21:42
@krzywon krzywon mentioned this pull request Aug 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butlerpd butlerpd butlerpd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@krzywon @caitwolf @wpotrzebowski @butlerpd @rozyczko @pbeaucage @lucas-wilkins @drowssap61 @llimeht