Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed sesans residuals plots to show in real space rather than q space #2338

Merged
merged 1 commit into from
Oct 30, 2022
Merged

fixed sesans residuals plots to show in real space rather than q space #2338

merged 1 commit into from
Oct 30, 2022

Conversation

caitwolf
Copy link
Contributor

@caitwolf caitwolf commented Oct 30, 2022 •
edited by wpotrzebowski
Loading

Description

Fixed the SESANS residuals plot so they show in real space rather than q space.
Fixes #2337

How Has This Been Tested?

Plotting residuals for SESANS and regular SAS data.

Review Checklist (please remove items if they don't apply):

  • Code has been reviewed
  • Functionality has been tested
  • Windows installer (GH artifact) has been tested (installed and worked)
  • Mac installer (GH artifact) has been tested (installed and worked)
  • User documentation is available and complete (if required)
  • Developers documentation is available and complete (if required)
  • The introduced changes comply with SasView license (BSD 3-Clause)

@caitwolf caitwolf linked an issue Oct 30, 2022 that may be closed by this pull request
SESANS residuals plot shown in Q space rather than real space #2337
Closed
@butlerpd butlerpd self-requested a review October 30, 2022 18:40
butlerpd
butlerpd approved these changes Oct 30, 2022
View reviewed changes
Copy link
Member

@butlerpd butlerpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good. tested functionality (residuals are much better now 👍 ) on windows. Only mac build not tested, but for this change I don't think that is required. I approve and recommend merging with or without a mac OS test

@lucas-wilkins
Copy link
Contributor

I approve and recommend merging with or without a mac OS test

I think this is the issue with having these checkboxes.

@wpotrzebowski wpotrzebowski self-requested a review October 30, 2022 19:33
@wpotrzebowski wpotrzebowski merged commit 88df426 into main Oct 30, 2022
@wpotrzebowski wpotrzebowski deleted the 2337-sesans-residuals-plot-shown-in-q-space-rather-than-real-space branch October 30, 2022 19:34
@caitwolf caitwolf mentioned this pull request Jan 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpotrzebowski wpotrzebowski wpotrzebowski approved these changes

@butlerpd butlerpd butlerpd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SESANS residuals plot shown in Q space rather than real space
4 participants
@caitwolf @lucas-wilkins @wpotrzebowski @butlerpd