Fit intermittent plot blanking (#2267) #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rozyczko
approved these changes
Oct 27, 2022
There was a problem hiding this comment.
Code looks good.
All three places behave correctly:
- on reset graph range
- on hide/show error bars
- on plot removal
I can't reproduce the original issue reliably, so can't comment on the applicability of the fix but it seems to be a step in the right direction.
A general improvement in chart responsiveness is also visible.
pbeaucage
commented
Oct 27, 2022
pbeaucage
commented
Oct 27, 2022
wpotrzebowski
approved these changes
Oct 27, 2022
wpotrzebowski
deleted the
2267-plot-limits-intermittently-reset-to-01-on-all-axes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2267 by commenting out calls to
matplotlib.pyplot.cla()which were already paired with the more specific alternative calls toself.ax.cla()(at best a duplicate, at worst it causes arbitrary plots to blank themselves as seen here.It would be worth eyes from @rozyczko and @krzywon who wrote this originally to see if there's some reason I'm missing for the
plt.cla()call. It seems to now work fine on my machine. The tell, even without a way to reproduce, is that when data is "Compute/Plot"'d on Main the plot briefly will flash to a white background with default axes from 0 to 1, linear, on both axes. That no longer happens on this branch, at least for me. Or see reproduction instructions in #2267.