Merge pull request #663 from Scalingo/fix/657/backups_download

fix(backup-download) Now download the last successful backup

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 * bump github.com/fatih/color from 1.11.0 to 1.12.0: add support for `NO_COLOR` environment variable.
 * bump github.com/briandowns/spinner from 1.12.0 to 1.13.0
+* fix(backup-download) Now download the last successful backup [#663](https://github.com/Scalingo/cli/pull/663)
 
 ### 1.20.2
 

db/backup_download.go

@@ -9,6 +9,7 @@ import (
 	"time"
 
 	"github.com/Scalingo/cli/config"
+	"github.com/Scalingo/go-scalingo/v4"
 	"github.com/Scalingo/go-scalingo/v4/debug"
 	"github.com/briandowns/spinner"
 	"github.com/cheggaaa/pb"
@@ -48,10 +49,13 @@ func DownloadBackup(app, addon, backupID string, opts DownloadBackupOpts) error
 			return errgo.Notef(err, "fail to get the most recent backup")
 		}
 		if len(backups) == 0 {
-			return errgo.New("This addon has no backup")
+			return errgo.New("this addon has no backup")
 		}
-		backupID = backups[0].ID
-		fmt.Fprintln(logWriter, "-----> Selected the most recent backup")
+		backupID, err = getLastSuccessfulBackup(backups)
+		if err != nil {
+			return errgo.Notef(err, "fail to get a successful backup")
+		}
+		fmt.Fprintln(logWriter, "-----> Selected the most recent successful backup")
 	}
 
 	// Start a spinner when loading metadatas
@@ -131,3 +135,12 @@ func isDir(path string) bool {
 
 	return s.IsDir()
 }
+
+func getLastSuccessfulBackup(backups []scalingo.Backup) (string, error) {
+	for _, backup := range backups {
+		if backup.Status == scalingo.BackupStatusDone {
+			return backup.ID, nil
+		}
+	}
+	return "", errgo.New("can't find any successful backup")
+}