Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backup-download) Now download the last successful backup #663

Merged
merged 4 commits into from
Jun 3, 2021

Conversation

TheoEb
Copy link
Contributor

@TheoEb TheoEb commented Jun 2, 2021

Add loops to range over the last backups until we find a successful one to download.
Still return an error if there is none.

Fix #657

  • Add a changelog entry in the section "To Be Released" of CHANGELOG.md

@TheoEb TheoEb self-assigned this Jun 2, 2021
@TheoEb TheoEb requested a review from EtienneM June 2, 2021 15:53
Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your commits are unverified because "The email in this signature doesn’t match the committer email."
Do you have the commiter email in your GitHub profile?

db/backup_download.go Outdated Show resolved Hide resolved
@TheoEb TheoEb force-pushed the fix/657/backups_download branch from e4be853 to 966969e Compare June 3, 2021 08:31
@TheoEb TheoEb requested a review from EtienneM June 3, 2021 08:36
db/backup_download.go Outdated Show resolved Hide resolved
@TheoEb TheoEb requested a review from EtienneM June 3, 2021 10:30
@EtienneM EtienneM merged commit da7032d into master Jun 3, 2021
@EtienneM EtienneM deleted the fix/657/backups_download branch June 3, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[backups-download] Should download the latest successfull backup
2 participants