Update with change sets for multiple stacks fails unless all cause updates #723
Comments
henrist
changed the title
|
This is why it fails: The code requires all items in the plan to have updates |
|
As far as I know, this is still an issue in @henrist any chance of creating that pull request with the hacking you did on this issue? Might be able to help on solving this issue so it can be merged into upstream. |
|
This now might work when 20b824a was merged to master (not formally released yet) |
|
I'll devote some time during the weekend to check (both the changes mentioned and if needed push som partial changes in a PR). |
Previously the update command would exit if any change sets status was not equal to READY. However, when a stack does not contain any updates, it will not be READY since there is nothing to execute. This should not prevent other change sets to be executed. Fixes Sceptre#723
Previously the update command would exit if any change sets status was not equal to READY. However, when a stack does not contain any updates, it will not be READY since there is nothing to execute. This should not prevent other change sets to be executed. [Resolves Sceptre#723]
Previously the update command would exit if any change sets status was not equal to READY. However, when a stack does not contain any updates, it will not be READY since there is nothing to execute. This should not prevent other change sets to be executed. [Resolves Sceptre#723]
Previously the update command would exit if any change sets status was not equal to READY. However, when a stack does not contain any updates, it will not be READY since there is nothing to execute. This should not prevent other change sets to be executed. [Resolves Sceptre#723]
|
The PR is out - see #917 |
|
Thanks I’ll have a look soon I take it master doesn’t work? |
Yep, correct. The code i refered to in #723 (comment) still caused the bailout. |
Previously the update command would exit if any change sets status was not equal to READY. However, when a stack does not contain any updates, it will not be READY since there is nothing to execute. This should not prevent other change sets to be executed. [Resolves Sceptre#723]
…le stacks Previously the update command would exit if any change sets status was not equal to READY. However, when a stack does not contain any updates, it will not be READY since there is nothing to execute. This should not prevent other change sets to be executed. To get around this, we introduce another change set status, NO_CHANGES, and handle that gracefully. To clean up the output a bit, we also pass on describing the changes for empty change sets.
update -c xxxfails if there are multiple stacks resolved, and not all have updates (i.e. generates valid change sets). This is due to not all change sets statuses being READY, so it bails withexit(1).Party covered in #520, but this is a bug, not a broader improvement.
I've done some initial hacking on this issue and will try to push a PR soon.
The text was updated successfully, but these errors were encountered: