Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resolve #723] Fix update command with change sets for multiple stacks #1480

Conversation

alex-harvey-z3q
Copy link
Contributor

@alex-harvey-z3q alex-harvey-z3q commented Jun 23, 2024

I am adopting this stale PR
#1192


Resolves #723

Previously the update command would exit if any change sets status
was not equal to READY. However, when a stack does not contain
any updates, it will not be READY since there is nothing to execute.
This should not prevent other change sets to be executed.

To get around this, we introduce another change set status, NO_CHANGES,
and handle that gracefully.

To clean up the output a bit, we also pass on describing the changes
for empty change sets.

Continuation of #917. Thanks @henrist for the original PR and @jfalkenstein for the review:

  • Fix original PR feedback
  • Simplify code for skipping output for empty change set
  • Roll back optional delete, we should always clean up
  • Add test covering "change set" version of update command

PR Checklist

  • Wrote a good commit message & description [see guide below].
  • Commit message starts with [Resolve #issue-number].
  • Added/Updated unit tests.
  • Added/Updated integration tests (if applicable).
  • All unit tests (poetry run tox) are passing.
  • Used the same coding conventions as the rest of the project.
  • The new code passes pre-commit validations (poetry run pre-commit run --all-files).
  • The PR relates to only one subject with a clear title.
    and description in grammatically correct, complete sentences.

Approver/Reviewer Checklist

  • Before merge squash related commits.

Other Information

Guide to writing a good commit

henrist and others added 3 commits January 13, 2022 23:20
…le stacks

Previously the update command would exit if any change sets status
was not equal to READY. However, when a stack does not contain
any updates, it will not be READY since there is nothing to execute.
This should not prevent other change sets to be executed.

To get around this, we introduce another change set status, NO_CHANGES,
and handle that gracefully.

To clean up the output a bit, we also pass on describing the changes
for empty change sets.
@alex-harvey-z3q alex-harvey-z3q requested a review from zaro0508 June 23, 2024 04:52
@alex-harvey-z3q
Copy link
Contributor Author

Please also see my comments on the original PR to see how I have addressed Jon's request for changes.

@alex-harvey-z3q alex-harvey-z3q changed the title [Resolves #723] Fix update command with change sets for multiple stacks [Resolve #723] Fix update command with change sets for multiple stacks Jul 5, 2024
@alex-harvey-z3q
Copy link
Contributor Author

@alex-harvey-z3q alex-harvey-z3q merged commit 4a4e0c7 into Sceptre:master Aug 21, 2024
12 checks passed
@alex-harvey-z3q alex-harvey-z3q deleted the ah/harkylton/fix-update-changesets branch August 21, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update with change sets for multiple stacks fails unless all cause updates
3 participants