Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement feedback from alpha testers - part 3 (essential for beta) #1266

Open
2 tasks
larsrickert opened this issue Jun 10, 2024 · 1 comment
Open
2 tasks

Implement feedback from alpha testers - part 3 (essential for beta) #1266

larsrickert opened this issue Jun 10, 2024 · 1 comment
Labels
dev Requires technical expertise documentation Improvements or additions to documentation
Milestone
Release preparation

Comments

@larsrickert
Copy link
Collaborator

larsrickert commented Jun 10, 2024 •
edited by BoppLi
Loading

We received some feedback from our alpha testers / developers:

Other feedback is in

Feedback from 6th June

  • Nuxt: When importing icons, a type error is shown in the editor. Maybe we can include a .d.ts file or something in our @sit-onyx/icons for this
    • -> minimum: write docs in the icon library to create a .d.ts file 
        declare module "*?raw" {
    const src: string;
    export default src;
  }

Feedback from 13th June
@larsrickert larsrickert self-assigned this Jun 10, 2024
@larsrickert larsrickert added bug Something isn't working or not shown correctly dev Requires technical expertise labels Jun 10, 2024
@larsrickert larsrickert mentioned this issue Jun 10, 2024
Merged
10 tasks
larsrickert added a commit that referenced this issue Jun 12, 2024
@larsrickert
fix: implement feedback from alpha testers (#1267)
edbfc22 
Relates to #1266

- [x] OnxyTable: does not fit to the grid because it has `width:
fit-content;`
- [x] Docs: example for how to override onyx styles (`:deep()` selector)
- [x] Not all components are exported (mainly support components)
- [x] Docs: Mention layout components in getting started guide
- [x] Docs: Source code for `OnyxNavBar` shows `<component />` instead
of `<OnyxNavSeparator />`
- [x] OnyxNavSeparator: `Onyx` prefix is missing for source code
- [x] OnyxSelect: make more clear that search logic must be implemented
on project side
This was referenced Jun 12, 2024
Merged
Merged
larsrickert added a commit that referenced this issue Jun 12, 2024
@larsrickert
feat: support global.css file (#1280)
62cb2ca 
Relates to #1266

Support `global.css` file that can be optionally imported by a project
to apply global application styles.
Will be imported by default for Nuxt projects.
larsrickert added a commit that referenced this issue Jun 12, 2024
@larsrickert
fix(OnyxTable): make components interactive when showing column hover…
55c0b19 
… effect (#1283)

Relates to #1266

Interactive components did not work when used inside the OynxTable.
E.g. buttons inside the table header or row when the column hover effect
is shown.

Also the column hover effect is now hidden when moving the mouse down
from the header
This was referenced Jun 13, 2024
Merged
Merged
@JoCa96 JoCa96 mentioned this issue Jun 13, 2024
Merged
larsrickert added a commit that referenced this issue Jun 13, 2024
@larsrickert
docs: update truncation examples (#1305)
2a60c05 
Relates to #1266

- Update truncation examples to use the `style` attribute instead of a
Storybook decorator so it is included in the generated source code
- remove code duplication for the OnyxTable examples
@larsrickert larsrickert mentioned this issue Jun 18, 2024
Merged
2 tasks
larsrickert added a commit that referenced this issue Jun 18, 2024
@larsrickert
feat(OnyxSelect): support option slot (#1343)
107ec36 
Relates to #1266

Support new slot where custom option content can be placed
@JoCa96 JoCa96 mentioned this issue Jun 18, 2024
Merged
@JoCa96
Copy link
Collaborator

JoCa96 commented Jun 19, 2024

Moved done stuff to #1354

@mj-hof mj-hof added this to the Release preparation milestone Jun 19, 2024
@mj-hof mj-hof mentioned this issue Jun 19, 2024
Closed
JoCa96 added a commit that referenced this issue Jun 21, 2024
@JoCa96 @BoppLi
fix(OnyxNavAppArea): max-height not working correctly (#1352)
02f5691 
Relates to #1266

---------

Co-authored-by: Linda Bopp <151019977+BoppLi@users.noreply.github.com>
larsrickert pushed a commit that referenced this issue Jun 24, 2024
@JoCa96
fix(OnyxButton): keep label width when loading (#1307)
743ee88 
Relates to #1266 

* fix(OnyxButton): keep label width when loading
* fix(OnyxInput, OnyxTextarea): fix label tooltip not correctly
vertically aligned
@BoppLi BoppLi self-assigned this Jun 26, 2024
@BoppLi BoppLi mentioned this issue Jun 26, 2024
Merged
@BoppLi BoppLi changed the title Implement feedback from alpha testers Implement feedback from alpha testers - part 3 Jul 3, 2024
@BoppLi BoppLi added documentation Improvements or additions to documentation and removed bug Something isn't working or not shown correctly labels Jul 3, 2024
This was referenced Jul 3, 2024
Closed
Open
@BoppLi BoppLi changed the title Implement feedback from alpha testers - part 3 Implement feedback from alpha testers - part 3 (essential for beta) Jul 3, 2024
@JoCa96 JoCa96 mentioned this issue Jul 4, 2024
Merged
JoCa96 added a commit that referenced this issue Jul 4, 2024
@JoCa96
fix(typings): incorrect or outdated type definitions (#1513)
bf1e992 
Relates to #1266

- The `vite-plugin-dts` was removed and instead we use `vue-tsc` for the
generation of the type definitions.
- The plugin uses an outdated version of the
[`@vue/language-core`](https://www.npmjs.com/package/%40vue%2Flanguage-core)
package
 - Added typings to all `.eslintrc.cjs` files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev Requires technical expertise documentation Improvements or additions to documentation
Projects
onyx
Status: Ready
Milestone
Release preparation
Development

No branches or pull requests
4 participants
@JoCa96 @larsrickert @BoppLi @mj-hof