Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement feedback from alpha testers - part 4 (nice to have) #1498

Open
6 tasks
BoppLi opened this issue Jul 3, 2024 · 0 comments
Open
6 tasks

Implement feedback from alpha testers - part 4 (nice to have) #1498

BoppLi opened this issue Jul 3, 2024 · 0 comments
Assignees
Labels
dev Requires technical expertise

Comments

@BoppLi
Copy link
Contributor

BoppLi commented Jul 3, 2024

We received some feedback from our alpha testers / developers:

Other feedback is in:

Feedback from 6th June

  • JSDocs are missing for some properties when hovering over them in the IDE
    • -> Vue bug report needed
  • Icons: No intellisense when importing icons. Would be nice if icons are suggested / autocompleted
    • -> probably a bundle build step is needed. or a fancy ts config?

Feedback from 13th June

  • We could use Vitest type tests to e.g. test that generics work correctly (e.g. that value is Array if multiple prop is set etc.)
  • OnyxSelect: Not working with SSR (because we use document.getElementById() in the createListbox() which must only be accessed in onMounted())
  • i18n: Support lazy loading for locales
  • i18n: find easier to override specific translations which also works with lazy loading and multiple languages
@BoppLi BoppLi added the dev Requires technical expertise label Jul 3, 2024
@BoppLi BoppLi changed the title Implement feedback from alpha testers - part 4 Implement feedback from alpha testers - part 4 (nice to have) Jul 3, 2024
@BoppLi BoppLi added this to the Product improvements milestone Jul 3, 2024
larsrickert added a commit that referenced this issue Sep 13, 2024
…e components (#1844)

Relates to #1521

Support SSR for OnyxSelect, OnyxNavButton, OnyxUserMenu and more
components by:

- update to Vue 3.5
- replace custom `createId()` with Vue's new `useId()` which is SSR
compatible
- a few other SSR fixes
- also fixes the missing JSDoc for properties (see #1498)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Requires technical expertise
Projects
Status: Backlog
Development

No branches or pull requests

2 participants