Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support SSR for OnyxSelect, OnyxNavButton, OnyxUserMenu and more components #1844

Merged
merged 6 commits into from
Sep 13, 2024

Conversation

larsrickert
Copy link
Collaborator

@larsrickert larsrickert commented Sep 9, 2024

Relates to #1521

Support SSR for OnyxSelect, OnyxNavButton, OnyxUserMenu and more components by:

Checklist

  • The added / edited code has been documented with JSDoc
  • A changeset is added with npx changeset add if your changes should be released as npm package (because they affect the library usage)

Copy link

changeset-bot bot commented Sep 9, 2024

🦋 Changeset detected

Latest commit: c64b85f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@sit-onyx/headless Major
sit-onyx Major
demo-app Patch
playground Patch
@sit-onyx/chartjs-plugin Major
@sit-onyx/nuxt Major
@sit-onyx/storybook-utils Major
@sit-onyx/vitepress-theme Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@larsrickert
Copy link
Collaborator Author

To fix the storybook build we need to update to storybook 8.3 beta but we need to wait for storybookjs/storybook#28760 to be released first, otherwise property controls are missing for booleans and enum/union types

JoCa96
JoCa96 previously approved these changes Sep 11, 2024
@larsrickert larsrickert merged commit dc00809 into main Sep 13, 2024
19 checks passed
@larsrickert larsrickert deleted the fix/vue-3-5 branch September 13, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants