Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(@sit-onyx/storybook-utils): use global event decorators to automatically log events #1725

Merged
merged 29 commits into from
Sep 4, 2024
Merged

chore(@sit-onyx/storybook-utils): use global event decorators to automatically log events #1725

merged 29 commits into from
Sep 4, 2024

Conversation

JoCa96
Copy link
Collaborator

@JoCa96 JoCa96 commented Aug 8, 2024 •
edited
Loading

  • defineStorybookActionsAndVModels was deprecated: Replace by using the withVModelDecorator as a global decorator and the enhanceEventArgTypes global argTypesEnhancer.
  • withVModelDecorator with event array arguments was deprecated: It is not necessary anymore to define the events manually.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: c427ed4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sit-onyx/storybook-utils Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JoCa96 JoCa96 mentioned this pull request Aug 8, 2024
Merged
@JoCa96 JoCa96 force-pushed the joca96/chore-use-global-event-decorator branch from 4e27ae2 to 9e4dbdc Compare August 20, 2024 13:00
@JoCa96 JoCa96 marked this pull request as ready for review August 20, 2024 14:45
@JoCa96 JoCa96 requested a review from a team as a code owner August 20, 2024 14:45
@JoCa96 JoCa96 changed the title Joca96/chore use global event decorator chore(@sit-onyx/storybook-utils): use global event decorators to automatically log events Aug 21, 2024
@JoCa96 JoCa96 enabled auto-merge (squash) August 23, 2024 06:15
larsrickert
larsrickert previously approved these changes Aug 26, 2024
View reviewed changes
@JoCa96 JoCa96 merged commit b2b3700 into main Sep 4, 2024
19 checks passed
@JoCa96 JoCa96 deleted the joca96/chore-use-global-event-decorator branch September 4, 2024 13:58
@larsrickert larsrickert mentioned this pull request Sep 11, 2024
Merged
1 task
larsrickert added a commit that referenced this pull request Sep 11, 2024
@larsrickert
fix(enhanceEventArgTypes): log actions/events without "on" prefix (#1849
08a9d76 
)

Relates to #1725

In #1725 we implemented auto actions for all component events. However,
the actions/Events are logged with an "on" prefix, e.g. "onClick"
instead of "click" although the "real" component event name is just
"click" as it is defined with `defineEmits()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MajaZarkova MajaZarkova MajaZarkova approved these changes

@larsrickert larsrickert larsrickert left review comments

Assignees

@larsrickert larsrickert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoCa96 @MajaZarkova @larsrickert