Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(enhanceEventArgTypes): log actions/events without "on" prefix #1849

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

larsrickert
Copy link
Collaborator

Relates to #1725

In #1725 we implemented auto actions for all component events. However, the actions/Events are logged with an "on" prefix, e.g. "onClick" instead of "click" although the "real" component event name is just "click" as it is defined with defineEmits()

Checklist

  • A changeset is added with npx changeset add if your changes should be released as npm package (because they affect the library usage)

@larsrickert larsrickert requested a review from a team as a code owner September 11, 2024 09:28
Copy link

changeset-bot bot commented Sep 11, 2024

🦋 Changeset detected

Latest commit: 0404fd5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sit-onyx/storybook-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JoCa96 JoCa96 self-assigned this Sep 11, 2024
@larsrickert larsrickert merged commit 08a9d76 into main Sep 11, 2024
19 checks passed
@larsrickert larsrickert deleted the fix/storybook-action-event-names branch September 11, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants