STASH to CF mapping: unknown units

[tv3141]

import sys
sys.path.append('/FOO/miniconda/envs/ENV/lib/python2.7/site-packages/iris/fileformats')
import um_cf_map

stashs = [(k, v) for k, v in um_cf_map.STASH_TO_CF.items() if v.units == 'unknown']
for s in stashs:
    print s[0], s[1]

m01s15i219 CFName(standard_name='square_of_air_temperature', long_name=None, units='unknown')
m01s03i202 CFName(standard_name='downward_heat_flux_in_soil', long_name=None, units='unknown')
m01s15i228 CFName(standard_name='product_of_northward_wind_and_specific_humidity', long_name=None, units='unknown')
m01s15i220 CFName(standard_name='square_of_eastward_wind', long_name=None, units='unknown')
m01s15i221 CFName(standard_name='square_of_northward_wind', long_name=None, units='unknown')
m01s15i223 CFName(standard_name='product_of_omega_and_air_temperature', long_name=None, units='unknown')
m01s15i224 CFName(standard_name='product_of_eastward_wind_and_omega', long_name=None, units='unknown')
m01s15i225 CFName(standard_name='product_of_northward_wind_and_omega', long_name=None, units='unknown')
m01s15i226 CFName(standard_name='specific_humidity', long_name=None, units='unknown')
m01s15i227 CFName(standard_name='product_of_eastward_wind_and_specific_humidity', long_name=None, units='unknown')
m01s08i229 CFName(standard_name='mass_fraction_of_unfrozen_water_in_soil_moisture', long_name=None, units='unknown')
m01s15i239 CFName(standard_name='product_of_eastward_wind_and_geopotential_height', long_name=None, units='unknown')
m01s15i238 CFName(standard_name='geopotential_height', long_name=None, units='unknown')
m01s15i235 CFName(standard_name='product_of_omega_and_specific_humidity', long_name=None, units='unknown')
m01s15i240 CFName(standard_name='product_of_northward_wind_and_geopotential_height', long_name=None, units='unknown')
m01s08i230 CFName(standard_name='mass_fraction_of_frozen_water_in_soil_moisture', long_name=None, units='unknown')
m01s01i238 CFName(standard_name='tropopause_upwelling_shortwave_flux', long_name=None, units='unknown')
m01s08i208 CFName(standard_name='soil_moisture_content', long_name=None, units='unknown')
m01s08i209 CFName(standard_name='canopy_water_amount', long_name=None, units='unknown')
m01s05i212 CFName(standard_name='convective_cloud_area_fraction_in_atmosphere_layer', long_name=None, units='unknown')

[pelson]

Thanks @tv3141. Again, this data is source from a 3rd party, and ideally we'd update it there and pull in the changes automatically. In practice, I know this is harder than I'd like it to be though... 😞

[tv3141]

#3043 fixed this.
I think it would be good to enforce this in iris with a test. I would be happy to add this.
What do you think @pelson?

[pelson]

I think it would be good to enforce this in iris with a test.

I'm not sure exactly what you are proposing. Would you like a test to assert that no mappings have 'unknown' units? Given this is generated code, why not just put this in the tool to avoid it in the first place? xref: https://github.com/SciTools/iris/tree/master/tools

[github-actions]

In order to maintain a backlog of relevant issues, we automatically label them as stale after 500 days of inactivity.

If this issue is still important to you, then please comment on this issue and the stale label will be removed.

Otherwise this issue will be automatically closed in 28 days time.

[github-actions]

This stale issue has been automatically closed due to a lack of community activity.

If you still care about this issue, then please either:

• Re-open this issue, if you have sufficient permissions, or
• Add a comment pinging @SciTools/iris-devs who will re-open on your behalf.