-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support CRS datum information #4619
Comments
I have an example notebook which should help demonstrate the issue and hopefully also help test a fix (there are a few caveats that need to explain, so I will bring it to surgery later) |
When #4617 lands, then we'll have votable issues 🚀 So up-voting this issue really does matter 😄 And will really help us prioritise and focus on issues that the community really wants us to solved. |
CF support for a datum is mentioned in the description above, but it does not explicitly mention that the CF Convention optional grid mapping attribute called Having come late to this, apologies if I'm missed the subtleties of this request. |
|
@nhsavage - thanks for the clarification. I'd assumed that it might be easiest to include 'crs_wkt' as it's just text, but that's assuming you treat it as a 'blob', whereas I think you're suggested this this should be handled more intelligently in Iris, which would be great! |
#4643 would be a solution to this. |
✨ Feature Request
Support for the
datum
attribute of a coordinate reference system.Motivation
Higher resolution modelling is now revealing slight discrepancies when transforming between different coordinate systems. Through various discussions, including on met office yammer, the key underlying issue appears to be that
iris.coord_system.CoordSystem
has no concept of a "datum", so are therefore missing information about positions on the surface of the earth relative to an ellipsoid (see this document for details).It seems that the easiest way to support this, from where iris currently stands is to:
Add a
datum
attribute toiris.coord_system.CoordSystem
subclasses.Modify these methods to pass the datum to cartopy.
Most code that does any kind of coordinate transformation with iris (including plotting and regridding) goes via at least one of these methods, either explicitly or implicitly, so fixing it here is crucial. Cartopy can handle datum shifts (it uses PROJ via pyproj, which does support this), but it is (almost) never told about the datum by iris.
Allow loading this from a file. The CF conventions do specify how to represent a datum in a netCDF file. Though I suspect that many files in practice do not have this information, so it should also be easy for the user to set one manually, and ideally this should be made clear in the documentation somewhere.
Ensure the new datum information is saved to a (netCDF) file, to minimise the chance of related issues arising in the future.
The text was updated successfully, but these errors were encountered: