PP constraint #1240
Merged
PP constraint #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
👍 from me too! Tests show reading in a pp field from a list of files which contain several fields is sped up by a factor of 12. This is the sort of a gain in performance that would really encourage users to take up Iris. |
| @@ -1677,8 +1677,35 @@ def reset_save_rules(): | |||
|
|
|||
| _save_rules = None | |||
|
|
|||
| def _convert_constraints(constraints): | |||
There was a problem hiding this comment.
PEP8 wants an extra blank line here
|
Nice work, it all fits in a lot more neatly than I'd have expected. |
| # | ||
| # You should have received a copy of the GNU Lesser General Public License | ||
| # along with Iris. If not, see <http://www.gnu.org/licenses/>. | ||
| """Unit tests for :func:`iris.fileformats.rules.load_cubes`.""" |
There was a problem hiding this comment.
Since it moved, this isn't quite right any more -- also the filename (or path?) now needs to give it a bit more context.
|
other than #1240 (comment) , all ok now I think. |
|
Great stuff ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
additional to #1237, targeted at 1.7.x