-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adopt conda-forge #2441
adopt conda-forge #2441
Conversation
Some tests will continue to fail even if the above is merged, until a thread-safe hdf5 is available on conda-forge (see conda-forge/hdf5-feedstock#48) |
In case this went unnoticed, there is a thread-safe build on conda-forge now. |
Edit: Moved to a separate PR: #2477 Due to some changes in Numpy 1.12, some aggregator functions in I've modified the checking code to use |
this PR is ready to go, all the tests are passing and conda-forge is providing all of the testing matrix The developers proximate to me have all met and discussed the strengths and weaknesses of this approach. We have reached a consensus that the benefits outweigh the costs |
Is there a reason why we are testing against python3.5 and not python3.6? I assume there are missing dependencies for 3.6 at this time on conda-forge? Either way, It would be good detail the reasoning description of this ticket. People are trying to use iris with 3.6, see #2481. |
In addition, the INSTALL instructions still suggest we support python 3.4 not 3.5: |
i have working environments of iris with python 3.4 this is only a minimum, i don't think that the minimum version of Python has changed to 3.5, just the version we are testing with on travis
we chose to move from 3.4 to 3.5 to ensure dependency resolution and as a minimal change in order to adopt conda forge we will look to move testing to 3.6, but not as part of this piece of work, that will be planned as a future activity |
Thanks @marqh |
Run Travis tests using the conda-forge channel. Will fail until #2440 is merged.