Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py for pypi #2585

Closed
wants to merge 2 commits into from
Closed

setup.py for pypi #2585

wants to merge 2 commits into from

Conversation

marqh
Copy link
Member

@marqh marqh commented May 26, 2017

proposed replacement for #2544

setup.py Outdated
author='Iris, SciTools, UK Met Office',
maintainer='Iris, SciTools',
license='LGPLv3',
platforms='any',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marqh platforms='any' ... really? Commodore64, please!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this even used any more? I though it was more in classifiers.

@marqh
Copy link
Member Author

marqh commented Jun 8, 2017

@bjlittle any further requests for change on this?
is it good to merge?

@pelson
Copy link
Member

pelson commented Jun 21, 2017

I left a review comment at #2544 (comment). Essentially, given http://legacy.python.org/dev/peps/pep-0423/#top-level-namespace-relates-to-code-ownership, I'd favour naming it scitools-iris.

@marqh
Copy link
Member Author

marqh commented Jul 13, 2017

given http://legacy.python.org/dev/peps/pep-0423/#top-level-namespace-relates-to-code-ownership, I'd favour naming it scitools-iris.

0423 seems to be related to namespace in code. there is no implication here on namespace in code, the namespace for iris is iris

this name only affects pypi naming and pip install as far as i can see.

pip install iris-scitools

seems more intuitive to me than

pip install scitools-iris

and i would prefer

pip search iris | sort to group iris-scitools with other irises to aid informed choice on install

how do objectors address the comment from @lbdreyer:

I think I prefer iris-scitools with 'iris' at the start. If the packages were sorted alphabetically, and someone looked for iris they'd find iris-scitools nearby.
#2544 (comment)

if I were to flipflop, would this just get merged, or would it fire off further "i'd prefer it the other way" comments?

@pelson
Copy link
Member

pelson commented Nov 14, 2017

Closed by #2890.

@pelson pelson closed this Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants