Remove deprecated ignore args #2690
Conversation
|
@lbdreyer you have not updated cube math functionality to match the changes you've made to the analysis/maths API; see cube.py:L3080-L3109. |
| 'add/subtract. This functionality is now automatic. ' | ||
| 'The provided value to "ignore" has been ignored, ' | ||
| 'and has been automatically calculated.') | ||
| warn_deprecated(msg) |
There was a problem hiding this comment.
Now that you've removed this usage of warn_deprecated you'll also need to remove the import on L34.
I had tried grep-ing for usages of add and subtract but clearly didn't find these |
|
@lbdreyer don't worry! I only knew they were there because I was doing some work in that area as part of the dask integration work... |
|
@dkillick I am happy with Laura's changes here, and will merge if you can confirm that the review changes that you requested are now approved. (I have checked them but I don't like to see a big red cross sitting on a PR that I want to merge.) |
|
Build failed due to Travis Python version issue: #2769 (comment) Issue has been resolved, but I am unsure of next steps... |
3 participants
Fixes #2656
Fixes #2657