Remove deprecated module ff.py #2693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@dkillick What about the module iris.fileformats._ff.py and iris.fileformats._ff_cross_references.py? Do we still need them? |
Member
Author
|
@corinnebosley see #2641 (comment) for more detail. |
Member
|
@dkillick Sorted. In that case I'm happy to merge this. |
Member
|
Build failed due to Travis Python version issue: #2769 (comment) Issue has been resolved, but I am unsure of next steps... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the deprecated module
iris.fileformats.ff, and the test moduletest__ff_equivalents, which existed to check thatff.pyand_ff.pybehaved the same. Now thatff.pyhas been removed, we don't need that test module.Fixes #2641.