Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some what's new information about #2435 and #2810. #2876

Merged
merged 1 commit into from
Nov 1, 2017

Conversation

pelson
Copy link
Member

@pelson pelson commented Oct 27, 2017

I'm aware that it is very terse - it will need editorial along with the rest of the "what's new" items.

Copy link
Member

@DPeterK DPeterK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pelson these are basically fine; I've just made a couple of comments as a record of what could be done.

@@ -0,0 +1 @@
* The deprecated :mod:`iris.fileformats.grib` was removed. All iris GRIB functionality is now delivered through :mod:`iris-grib`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"iris" --> "Iris".

@@ -0,0 +1 @@
* In Iris v1 it was possible to configure Iris to log at import time through :attr:`iris.config.LOGGING`. This capability has been removed in iris 2.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"to log at import time": to log what at import time?

"iris 2" --> "Iris v2"

@DPeterK
Copy link
Member

DPeterK commented Oct 31, 2017

@pelson I think a rebase might solve the failing tests...

@pelson
Copy link
Member Author

pelson commented Oct 31, 2017

That should do it...

@DPeterK DPeterK merged commit 7be3ba8 into SciTools:master Nov 1, 2017
@pelson pelson deleted the docs_whats_new_2 branch November 2, 2017 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants