Set the documentation build to use viridis as the default colormap #2889
Conversation
pelson
force-pushed
the
viridis_for_docs
branch
2 times, most recently
from
68ee4b0 to
d88dd44
Compare
…ather than Jet as we are using matplotlib 1 still).
pelson
force-pushed
the
viridis_for_docs
branch
from
d88dd44 to
6d09016
Compare
| @@ -131,8 +131,10 @@ script: | |||
| # affect any downstream functionality but causes the build to fail | |||
| # spuriously. The echo-backtick workaround gets around this error, | |||
| # which should be investigated further in the future. | |||
| - if [[ $TEST_TARGET == 'doctest' ]]; then | |||
| - > | |||
There was a problem hiding this comment.
What does this add that we didn't have before?
There was a problem hiding this comment.
Tells yaml to go into multi-line mode, and prevents travis from going crazy from the newly added pipe line. Without it, travis can't even read the config file.
There was a problem hiding this comment.
Previously, everything was concatenated into one line, so theoretically, you could also drop the semicolons on every line here as well.
There was a problem hiding this comment.
Good to know. I'm tempted to do this once a few of the changes to the travis.yml have been merged.
| @@ -29,7 +29,7 @@ | |||
| // Only use first 5 images | |||
| for (var i = 0; i < 5; i++) { | |||
| var img = images[i]; | |||
| $ss.append('<a href="'+img[2]+'"><img src="'+img[1]+'" class="slideshowImage"/></a>'); | |||
| $ss.append('<a href="'+img[2]+'" style="background-color: white;" ><img src="'+img[1]+'" class="slideshowImage"/></a>'); | |||
There was a problem hiding this comment.
While I understand what this is doing I don't understand why it's needed – I haven't seen a problem with the slideshow that should require such a CSS change...
There was a problem hiding this comment.
I'm on Chrome for OSX 61.0.3163.100.
Visiting https://scitools-docs.github.io/iris/master/index.html.
There was a problem hiding this comment.
Ah – note the difference to http://scitools.org.uk/iris/docs/latest/index.html (where the above black bars never appear, so I'll not add an image!).
|
Just to be clear to anybody doing any investigation on when the colormap changed - viridis isn't necessarily the best colormap, but in all circumstances, it is significantly better than jet as a default. Happy for individual examples to set their own colormaps on a per-example basis. |
This is necessary because we still have mpl 1, not 2.
In addition, I was finding that the image scroller on the homepage was showing a black background for unusually shaped images. I fixed this by setting the background to white - it would be awesome to have a thorough refresh of the docs' styling, but I didn't get around to doing that yet.