Fix iris-test-data skips in Travis testing. #2972
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pp-mo
changed the title
pp-mo
force-pushed
the
fix_testdata
branch
2 times, most recently
from
3d603f3 to
5856c2e
Compare
Member
Author
Closed
pp-mo
changed the title
bjlittle
reviewed
Mar 14, 2018
| SITE_CFG=lib/iris/etc/site.cfg; | ||
| echo "[Resources]" > $SITE_CFG; | ||
| echo "test_data_dir = $(pwd)/iris-test-data/test_data" >> $SITE_CFG; | ||
| echo "doc_dir = $(pwd)/docs/iris" >> $SITE_CFG; |
Member
There was a problem hiding this comment.
The doc_dir is still referenced within iris/tests/runner/_runner.py and iris/tests/test_coding_standards.py
Member
Author
In that case this is the "wrong" approach, and #2978 is the "right" one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that all tests using iris-test-data have been skipping for a while
-- as in all the visible log messages "SKIP: Tests(s) require external data."
-- e.g. : https://travis-ci.org/SciTools/iris/jobs/341527576#L3747
This is in fact since 8a327b4,
However, I'm bafflled as to why
The existing code in
.travis.ymlseems definitely wrong, because it createssite.cfgin the local directory, which is not the iris installation.I'm currently at a loss to explain how
iris.configpreviously managed to find the test data ??Anyway,
proposed here is to put the 'site.cfg' into the installation, which should fix it.Make test data available via
OVERRIDE_TEST_DATA_REPOSITORYenvironment variable.NOTE:
This won't fix all the existing test failures, due to the failure of
iris.tests.check_graphic.In fact, there will be a whole lot more of them ...