Conversation
4a47fe1 to
f1f1fb9
Compare
|
Hi @tv3141 - thanks for this work to fix an outstanding Iris issue! Looks like some changes to master mean that your PR now has some merge conflicts; would you mind rebasing to fix these conflicts? Thanks! |
|
@tv3141 This PR still looks good to me, but we need you to rebase please. This isn't as straightforward as the last two that I've rebased for you; I'll need you to make sure the conflicts are resolved correctly. |
|
@corinnebosley @dkillick I will rebase this as soon as I can. |
f1f1fb9 to
8285298
Compare
8285298 to
2811605
Compare
|
This still needs a bit of work. Also some tests fail because of |
|
Yeah that's a bit worrying isn't it? I'll look into the testing environment; could be that something's been updated which has broken subprocess. |
|
On second thoughts I'll leave it a bit and have another look if and when that's the only test which fails. |
> find lib -type f -exec sed -i 's/UserWarning/IrisUserWarning/g' {} +
> find lib -type f -exec sed -i 's/warn(msg)/warn(msg, IrisUserWarning)/g' {} +
1) Find warnings not using IrisUserWarning
> ack --python 'warn\((?!(.|\n|{})*(Warning|IrisDeprecation))' -A 1
2) Reformat to:
```python
msg = '...'
warnings.warn(msg, IrisUserWarning, ...)
```
a37a22d to
45d6bd3
Compare
2a0d234 to
73a8d4b
Compare
The problem was that the file did not exists. The root cause was missing indentation. I added #3219 to make this more verbose. |
There was a problem hiding this comment.
So far I followed the warning docs on testing. This results in brittle tests that fail when the executed code creates FutureWarnings like we see them currently.
I think it is better to look for the warnings I want to test and re-emit all other warnings so that they are shown in the test log: 9eb61dd
|
@tv3141 Firstly, thanks for this awesome PR 👍 Sadly it's went rather stale. Also, we've decided to adopt Thanks again |
Closes #3078
IrisUserWarningand uses it where aUserWarningwas raised before. This allows the silencing of allIrisUserWarningsfrom Iris without silencingUserWarningsfrom other libraries.IrisUserWarnings(this can be made more specific)