Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinned cftime to less than 1.0.2.1 #3215

Merged
merged 3 commits into from
Nov 7, 2018

Conversation

corinnebosley
Copy link
Member

No description provided.

@bjlittle bjlittle self-requested a review November 7, 2018 11:32
@bjlittle
Copy link
Member

bjlittle commented Nov 7, 2018

The latest release of cftime at 1.0.2.1 is breaking iris master in travis-ci.

Happy to have a short-term pin to maintain functioning tests, whilst we investigate the underlying issue with latest cftime version.

@bjlittle bjlittle merged commit 99fe6d8 into SciTools:master Nov 7, 2018
@corinnebosley
Copy link
Member Author

thanks @bjlittle

@DPeterK
Copy link
Member

DPeterK commented Nov 7, 2018

Y'know, looking at the cftime releases, I wonder whether we should be using v1.0.0 - that seems to be the most recent "proper" release.

@DPeterK
Copy link
Member

DPeterK commented Nov 7, 2018

Here's the line causing the error about the date 0000-00-00: Unidata/cftime@v1.0.0...master#diff-9225bec7bdd479a2dfbc187bb72953d1R1814. At a guess it's actually complaining about month 00 rather than year 0000. Question is, why is Iris passing such a date?

@rcomer rcomer mentioned this pull request Dec 8, 2018
@cpelley cpelley mentioned this pull request Jan 7, 2019
znicholls pushed a commit to znicholls/iris that referenced this pull request Jun 15, 2019
* pinned cftime to less than 1.0.2.1

* pinned cftime to 1.0.1

* pinned cftime to not 1.0.2.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants