Conversation
stickler-ci
reviewed
Jul 9, 2019
lib/iris/tests/test_basic_maths.py
Outdated
| self.assertRaises(TypeError, iris.analysis.maths.IFunc, math.sqrt, | ||
| lambda cube: cf_units.Unit('1')) | ||
| if six.PY2: | ||
| # should fail because math.sqrt is built-in function, which can not be |
There was a problem hiding this comment.
E501 line too long (82 > 79 characters)
pp-mo
reviewed
Jul 9, 2019
Member
pp-mo
left a comment
pp-mo
left a comment
There was a problem hiding this comment.
One tiny query...
Rest all makes sense, LGTM 👍
Member
Author
|
Awesome sauce, thanks @pp-mo |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the travis-ci tests. It also tidies the
.travis-ciscript some what.Additionally, it also extends the testing to incorporate Python 3.7. So now we have coverage of Python 2.7, 3.6 and 3.7.... well, I say 2.7, but not for long 😉
Note that, we need to pin to
dask<2as there is some odd behaviour that is difficult to track-down and resolve for 3.6 and 3.7. As such, I've create this issue #3349.I'm only happy to pin short-term, and investigate (and fix) the underlying issue asap, but pinning seems appropriate here in order to unblock PRs with successful CI.
Note that, I've moved to
language: minimal, as this may speed-up the spin-up time of travis, see Travis CI - Minimal and Generic Images. Also, since we're usingminicondato control our use of packages and Python, there is actually no need to use Python as provisioned with a Travis CIlanguage: pythonimage.