Update ng-vat with recent changes+fixes from master#3685
Merged
trexfeathers merged 18 commits intong-vatfrom Mar 18, 2020
Merged
Update ng-vat with recent changes+fixes from master#3685trexfeathers merged 18 commits intong-vatfrom
trexfeathers merged 18 commits intong-vatfrom
Conversation
* Stop PPDataProxy accessing the file when no data is needed. (#3659) * Add 2.4 whatsnew into full whatsnew list. Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>
Merged
* New image hash for iris.test.test_plot.TestSymbols.test_cloud_cover with matplotlib 3.2.0. * Further images changes for mpl3x2. * Yet more updated image results.
* Correct and improve dev-guide section on fixing graphics-tests. * Review changes + general rethink. * Reduce duplication between 'graphics-tests' and general 'tests' page. * Update docs/iris/src/developers_guide/graphics_tests.rst Co-Authored-By: Martin Yeo <40734014+trexfeathers@users.noreply.github.com> * Update docs/iris/src/developers_guide/graphics_tests.rst Co-Authored-By: Martin Yeo <40734014+trexfeathers@users.noreply.github.com> * Update docs/iris/src/developers_guide/graphics_tests.rst Co-Authored-By: Martin Yeo <40734014+trexfeathers@users.noreply.github.com> * Update docs/iris/src/developers_guide/graphics_tests.rst Co-Authored-By: Martin Yeo <40734014+trexfeathers@users.noreply.github.com> * Update docs/iris/src/developers_guide/graphics_tests.rst Co-Authored-By: Martin Yeo <40734014+trexfeathers@users.noreply.github.com> Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>
trexfeathers
approved these changes
Mar 18, 2020
Contributor
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
Have double checked that these 18 commits are indeed identical to the commits that have taken place on master since branching. All good, LGTM ✨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
do not merge :CAN NOW MERGE ! 😁
ng-vat branch is currently a bit behind.
Would like this updated, to make #3684 more intelligible