Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loader-specific args in iris load functions. #3720

Closed
wants to merge 1 commit into from

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented May 27, 2020

This has been requested, to support #3647.
Previously considered for other cases, e.g. #3333 (but we didn't proceed with that).

Note: decided not to implement arbtrary additional (unnamed) args here, as the already optional positional args (constraints, callback) would make that rather messy.
We could still implement **kwargs instead of a specific keyword, if preferred? But I thought that might also lead to confusion..

Note: the changes reach further than I had imagined (into iris.fileformats and iris.io), but I believe this still does not introduce any breaking changes. Nevertheless, I've marked it up for Iris 3.0

@pp-mo
Copy link
Member Author

pp-mo commented Feb 7, 2022

I'm reviving this because I am again contemplating #3333 following some further experience with problem cases.
It will be needed to implement that.

Unfortunately we currently have a train wreck in the CI due to a problem with latest-version matplotlib docs.
So will come back here when that is fixed

@pp-mo
Copy link
Member Author

pp-mo commented Feb 9, 2022

#4572 now proposes an alternative control mechanism.
I'm thinking this is actually superior to load kwargs, because it groups control features in separate areas?

@pp-mo
Copy link
Member Author

pp-mo commented Sep 7, 2022

Not currently needed / no driver
We can re-open if needed

plus ... much of this (like chunking control) could be done with context managers instead ?
-- like the unstructured load

@pp-mo pp-mo closed this Sep 7, 2022
@pp-mo pp-mo deleted the load_controls branch October 20, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants