whatsnew - using the author github id#3849
Merged
trexfeathers merged 2 commits intoSciTools:masterfrom Sep 15, 2020
Merged
Conversation
Member
Author
|
ping @SciTools/iris-devs |
Member
|
It also means they can all be consistent, as everyone has a GitHub ID but not everyone has a GitHub name 👍 . |
Contributor
|
Thanks @bjlittle, LGTM |
trexfeathers
approved these changes
Sep 15, 2020
Member
Author
|
@trexfeathers Awesome, thanks! |
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Sep 15, 2020
* master: whatsnew - using the author github id (SciTools#3849) Bring SciTools#3804 whatsnew in line with format changes from SciTools#3838. (SciTools#3847) "What's New" credit and referencing (SciTools#3838) Allow passing None for all coord-system optional args. (SciTools#3804) var_name in AuxCoord created by trajectory.interpolate() (SciTools#3718)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This PR makes a simple change to the latest
whatsnewto opt to using and citing pull-request authors using their GitHub ID.On reflection, this might be a better long term approach as:
whatsnewentry, as they no longer have to "look up" the authors profile to determine whether their GitHub name matches their GitHub IDA built version of this pull-request is available on
readthedocs, to easily view the rendered changes:Consult Iris pull request check list