Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newcubesummary testsaffected #3962

Closed
wants to merge 19 commits into from

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Jan 27, 2021

Just a draft, opened to run the tests, replacing stephenworsley#8

Not ready for merging yet

  • includes all content from Refactor cube summary #3952
  • unit-testing is totally crude at present, needs breaking apart to test individual aspects.
    (I have a list somewhere)

This gives a headsup on ideas for the new code : CubePrinter converts CubeSummary into string reprs

This PR also plugs that mechanism into the cube string repr methods : cube.summary, .__str__ and .__repr__
This should show the effect on the tests

CURRENT STATUS:

  • problems with repr-html (working on it)
  • beautiful table to be added to the dependencies...

@pp-mo
Copy link
Member Author

pp-mo commented Jan 28, 2021

Bit nasty using pip again, but to fix we would need to create a recipe + builds (conda-forge)

The tests are now giving some idea of what it takes to integrate these changes (or similar)
But I am also working on that : some bugs uncovered + changes already in planning

@pp-mo
Copy link
Member Author

pp-mo commented Jan 28, 2021

Problems are already as few as 13 test failures.
I am still experimenting with slackening off the precision of some of these (ignoring some whitespace).
Also, some of the remaining presentation changes may be acceptable/desirable

@pp-mo pp-mo mentioned this pull request Feb 5, 2021
@pp-mo
Copy link
Member Author

pp-mo commented Feb 5, 2021

Closing in favour of #3982 (or its successors)

@pp-mo pp-mo closed this Feb 5, 2021
@pp-mo pp-mo deleted the newcubesummary_testsaffected branch March 18, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants