Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate regrid conservative #4551

Merged
merged 2 commits into from
Jan 28, 2022

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Jan 28, 2022

As planned in #4394

@pp-mo pp-mo mentioned this pull request Jan 28, 2022
8 tasks
@wjbenfold wjbenfold self-requested a review January 28, 2022 13:28
Copy link
Contributor

@wjbenfold wjbenfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would appreciate @stephenworsley checking the code example for how to use esmf_regrid to replicate the behaviour as he's more experienced on that than me

@stephenworsley
Copy link
Contributor

LGTM. Would appreciate @stephenworsley checking the code example for how to use esmf_regrid to replicate the behaviour as he's more experienced on that than me

The use of esmf_regrid looks good to me.

@wjbenfold
Copy link
Contributor

Benchmarks passed on third try (no idea what was up there)

@wjbenfold wjbenfold merged commit 6bdc6d5 into SciTools:main Jan 28, 2022
@pp-mo pp-mo mentioned this pull request Jan 28, 2022
wjbenfold pushed a commit that referenced this pull request Jan 28, 2022
@pp-mo pp-mo deleted the deprecate_regrid_conservative branch January 31, 2022 15:10
tkknight added a commit to tkknight/iris that referenced this pull request Mar 16, 2022
* main: (64 commits)
  [pre-commit.ci] pre-commit autoupdate (SciTools#4587)
  fix test (SciTools#4585)
  Loading Benchmarks (SciTools#4477)
  Fix refresh lockfile worrkflow pull request title (SciTools#4579)
  gha: lockfiles labels and auto-pr details (SciTools#4578)
  Bump actions/script from 4 to 5.1.0 (SciTools#4576)
  Bump actions/stale from 4.0.0 to 4.1.0 (SciTools#4575)
  Bump peter-evans/create-pull-request from 3.8.2 to 3.12.1 (SciTools#4577)
  adopt dependabot GHA (SciTools#4568)
  New tool-agnostic ASV environment management (SciTools#4571)
  Updated environment lockfiles (SciTools#4567)
  Update version to 3.3.dev0 (SciTools#4565)
  Reset whats new (SciTools#4563)
  docs: move whatsnew (SciTools#4540)
  Deprecate regrids (SciTools#4548)
  Update latest.rst (SciTools#4556)
  Updated environment lockfiles (SciTools#4555)
  Added whatsnew for SciTools#4551. (SciTools#4553)
  Update SciTools#4505 doctests for SciTools#4528. (SciTools#4554)
  minor optimisations (SciTools#4549)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants