Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "v3.2.0rc0 whats new and version string" #4558

Closed
wants to merge 2 commits into from

Conversation

lbdreyer
Copy link
Member

Reverts #4557

This shouldn't have gone onto main!!
This was supposed to target the v3.2.x branch

@pp-mo
Copy link
Member

pp-mo commented Jan 31, 2022

Oh gosh, I should have spotted that !

Would it not be better to reset the main, than to add a reversion commit ?

@lbdreyer
Copy link
Member Author

Would it not be better to reset the main, than to add a reversion commit ?

Probably! I added the reversion commit as that it what github creates for you when you click "revert" on a merged PR.

I will try resetting main

Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to try to reset the branch first, if we can.
It seems to need an admin though, so let's wait + see if @bjlittle can help.

Hi @bjlittle 😉 !

@bjlittle
Copy link
Member

bjlittle commented Feb 1, 2022

@lbdreyer Just to let you know that @pp-mo and I successfully reset the main branch, so I'm going to close this PR now

Thanks 👍

@bjlittle bjlittle closed this Feb 1, 2022
@lbdreyer
Copy link
Member Author

lbdreyer commented Feb 1, 2022

@bjlittle Something still seems broken on main. The latest commit included the pre-commit change and my changes

@lbdreyer lbdreyer deleted the revert-4557-fix_whatnes branch February 15, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants