Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin theme #5129

Merged
merged 3 commits into from
Jan 5, 2023
Merged

Unpin theme #5129

merged 3 commits into from
Jan 5, 2023

Conversation

tkknight
Copy link
Contributor

@tkknight tkknight commented Jan 5, 2023

🚀 Pull Request

Description

Unpinned pydata-sphinx-theme and set the default to use the light version (not dark).

We can enable the dark mode (and the switcher) once our docs are dark mode friendly.

See #4795


Consult Iris pull request check list

@trexfeathers
Copy link
Contributor

trexfeathers commented Jan 5, 2023

image

This certainly seems to have to disabled the dark switch 👍

EDIT: this is actually fine. However the panels are no longer on the home page. Perhaps related to 5121?

@tkknight tkknight requested a review from trexfeathers January 5, 2023 10:29
@tkknight tkknight marked this pull request as ready for review January 5, 2023 10:29
@trexfeathers trexfeathers merged commit e1fae5e into SciTools:main Jan 5, 2023
tkknight added a commit to tkknight/iris that referenced this pull request Jan 5, 2023
* upstream/main:
  Unpin theme (SciTools#5129)
  link percentile as lazy option (SciTools#5128)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants