Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Python 3.11 #5226

Merged
merged 2 commits into from
Apr 21, 2023
Merged

Support Python 3.11 #5226

merged 2 commits into from
Apr 21, 2023

Conversation

rcomer
Copy link
Member

@rcomer rcomer commented Apr 1, 2023 •
edited
Loading

🚀 Pull Request

Description

Python 3.11 has been out for nearly 6 months now so I think we should officially support for the upcoming release.

I note @trexfeathers' comment at #5211 (comment), so appreciate you won't want to merge this immediately. 👀

Needs #5232

Consult Iris pull request check list

@rcomer
Copy link
Member Author

rcomer commented Apr 1, 2023 •
edited
Loading

Wow I managed to break all the tests. Seems I need some help!

I can report that the main tests and gallery tests all passed locally under 3.11.

@rcomer rcomer marked this pull request as draft April 1, 2023 14:03
@codecov
Copy link

codecov bot commented Apr 4, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (e48ea5e) 89.31% compared to head (fca04f1) 89.31%.

Additional details and impacted files 
@@           Coverage Diff            @@
##             main    #5226    +/-   ##
========================================
  Coverage   89.31%   89.31%            
========================================
  Files          88       88            
  Lines       22279    22279            
  Branches     4881     5355   +474     
========================================
  Hits        19898    19898            
  Misses       1635     1635            
  Partials      746      746

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rcomer
Copy link
Member Author

rcomer commented Apr 4, 2023

It's amazing the variety of errors you can generate by just not making sure your branch is up-to-date with upstream 🤦‍♀️

The doctest and linkcheck fails are probably due to #5232, though I can't see the specific errors in the logs. I am somewhat suspicious that readthedocs passed.

@rcomer rcomer mentioned this pull request Apr 4, 2023
Closed
@rcomer
Copy link
Member Author

rcomer commented Apr 5, 2023

I am somewhat suspicious that readthedocs passed.

It passed, but the rendered docs are not showing the calling sequence for e.g. cube instantiation. So I guess the failure is there but RTD is not registering the non-zero exit code?

@rcomer rcomer force-pushed the python311 branch 2 times, most recently from 43308ba to 6bae905 Compare April 14, 2023 16:29
@bjlittle bjlittle mentioned this pull request Apr 17, 2023
Closed
@rcomer
Copy link
Member Author

rcomer commented Apr 20, 2023

Behold my full set of green ticks ✅😎

@rcomer rcomer marked this pull request as ready for review April 20, 2023 20:10
@bjlittle bjlittle self-requested a review April 20, 2023 21:06
bjlittle
bjlittle requested changes Apr 20, 2023
View reviewed changes
Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rcomer Thanks for doing this 🍻

Just some minor comments to service, then I think we're good to go 👍

lib/iris/tests/unit/experimental/ugrid/mesh/test_Connectivity.py Outdated Show resolved Hide resolved
.github/workflows/ci-tests.yml Show resolved Hide resolved
@bjlittle
Copy link
Member

@rcomer I'd say that a whatsnew entry is defo also needed 💯

@trexfeathers trexfeathers mentioned this pull request Apr 21, 2023
Merged
@bjlittle bjlittle merged commit d58fca7 into SciTools:main Apr 21, 2023
@rcomer rcomer deleted the python311 branch April 21, 2023 09:58
bjlittle added a commit to bjlittle/iris that referenced this pull request Apr 21, 2023
@bjlittle
follow-thru with SciTools#5226
19c2826
trexfeathers pushed a commit that referenced this pull request Apr 21, 2023
@bjlittle
move setup.cfg to pyproject.toml (#5262)
949b296 
* move setup.cfg to pyproject.toml

* refactor after #5263

* refactor after #5259

* review actions - manifest pattern

* review actions

* add whatsnew entry

* follow-thru with #5226
tkknight added a commit to tkknight/iris that referenced this pull request Apr 22, 2023
@tkknight
Merge remote-tracking branch 'upstream/main' into apidoc_improvements
79d93b3 
* upstream/main:
  Updated environment lockfiles (SciTools#5270)
  Drop python3.8 support (SciTools#5269)
  build wheel from sdist, not src (SciTools#5266)
  Lazy netcdf saves (SciTools#5191)
  move setup.cfg to pyproject.toml (SciTools#5262)
  Support Python 3.11 (SciTools#5226)
  Remove Resolve test workaround (SciTools#5267)
  add missing whatsnew entry (SciTools#5265)
tkknight added a commit to tkknight/iris that referenced this pull request Apr 22, 2023
@tkknight
Merge remote-tracking branch 'upstream/main' into dark_theme
d9f4c5b 
* upstream/main: (61 commits)
  Updated environment lockfiles (SciTools#5270)
  Drop python3.8 support (SciTools#5269)
  build wheel from sdist, not src (SciTools#5266)
  Lazy netcdf saves (SciTools#5191)
  move setup.cfg to pyproject.toml (SciTools#5262)
  Support Python 3.11 (SciTools#5226)
  Remove Resolve test workaround (SciTools#5267)
  add missing whatsnew entry (SciTools#5265)
  make help (SciTools#5258)
  automate pypi manifest checking (SciTools#5259)
  drop sphinxcontrib-napoleon (SciTools#5263)
  add missing test result data (SciTools#5260)
  fix indentation and remove ref to ssstack (SciTools#5256)
  review actions
  update .git-blame-ignore-revs
  adopt codespell
  Adopt sphinx design (SciTools#5127)
  Bump scitools/workflows from 2023.04.2 to 2023.04.3 (SciTools#5253)
  refresh manual pypi publish instructions (SciTools#5252)
  Updated environment lockfiles (SciTools#5250)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjlittle bjlittle bjlittle approved these changes

Assignees
No one assigned
Labels
Type: Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rcomer @bjlittle