-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On demand pull request benchmark #5286
Conversation
This is ready to go now ✔ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good and I can see this being very useful!
Many thanks @lbdreyer! |
It looks like the overnight benchmark failed due to exceeding the allowed time (6 hours): Usually benchmarks seem to take 1 or 2 hours |
This is actually un-related. It looks like it was confused by the merge commit from I don't currently have a solution for this. It's down to the git intelligence in the following places: At least it only happens during merge-backs to |
|
🚀 Pull Request
Description
Enhances theRequest that this pull request be benchmarked to check if it introduces performance shifts
label.
benchmark-check
GHA workflow to allow developers to request that their pull request be benchmarked for performance shifts. This is achieved by adding the benchmark_thisDemonstrations
TODO:
Consult Iris pull request check list