Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On demand pull request benchmark #5286

Merged
merged 6 commits into from
Apr 27, 2023
Merged

Conversation

trexfeathers
Copy link
Contributor

@trexfeathers trexfeathers commented Apr 27, 2023

🚀 Pull Request

Description

Enhances the benchmark-check GHA workflow to allow developers to request that their pull request be benchmarked for performance shifts. This is achieved by adding the benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts label.

Demonstrations

TODO:

  • What's New

Consult Iris pull request check list

@trexfeathers
Copy link
Contributor Author

This is ready to go now ✔

Copy link
Member

@lbdreyer lbdreyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good and I can see this being very useful!

@lbdreyer lbdreyer merged commit a49b5ac into SciTools:main Apr 27, 2023
@trexfeathers
Copy link
Contributor Author

Many thanks @lbdreyer!

@lbdreyer
Copy link
Member

It looks like the overnight benchmark failed due to exceeding the allowed time (6 hours):
image

Usually benchmarks seem to take 1 or 2 hours

@trexfeathers
Copy link
Contributor Author

trexfeathers commented Apr 28, 2023

This is actually un-related. It looks like it was confused by the merge commit from v3.5.x - this branch originated 29 commits ago, so it tried to work through all of them (see this line in the workflow run).

I don't currently have a solution for this. It's down to the git intelligence in the following places:

At least it only happens during merge-backs to main.

@trexfeathers
Copy link
Contributor Author

... It's down to the git intelligence in the following places:

Also this block in bm_runner.py

@trexfeathers trexfeathers deleted the on_demand_bm2 branch May 3, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants