-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark improvements, including passing exceptions upwards #5289
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trexfeathers
added
the
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
label
Apr 28, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #5289 +/- ##
==========================================
+ Coverage 89.32% 89.35% +0.02%
==========================================
Files 89 89
Lines 22390 22417 +27
Branches 5374 5382 +8
==========================================
+ Hits 20000 20030 +30
+ Misses 1640 1639 -1
+ Partials 750 748 -2 ☔ View full report in Codecov by Sentry. |
trexfeathers
added
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
and removed
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
labels
Apr 28, 2023
trexfeathers
added
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
and removed
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
labels
Apr 28, 2023
trexfeathers
added
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
and removed
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
labels
Apr 28, 2023
trexfeathers
added
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
and removed
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
labels
Apr 28, 2023
trexfeathers
added
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
and removed
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
labels
Apr 28, 2023
trexfeathers
added
Type: Performance
Type: Infrastructure
Type: Testing
and removed
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
labels
Apr 28, 2023
trexfeathers
added
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
and removed
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
labels
May 26, 2023
trexfeathers
added
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
and removed
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
labels
May 30, 2023
trexfeathers
added
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
and removed
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
labels
May 30, 2023
trexfeathers
added
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
and removed
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
labels
May 30, 2023
trexfeathers
added
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
and removed
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
labels
May 30, 2023
trexfeathers
added
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
and removed
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
labels
May 30, 2023
trexfeathers
added
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
and removed
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
labels
May 30, 2023
trexfeathers
added
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
and removed
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
labels
May 30, 2023
trexfeathers
added
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
and removed
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
labels
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
Type: Infrastructure
Type: Performance
Type: Testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
This benchmark run was requested for the penultimate commit (before the What's New entry).
Clearer exceptions/errors
subprocess.run
, causing the workflow to fail.CI usability improvements
asv continuous
, which uses an exit code of1
where performance regressions are found - so we're not relying on developers to manually read the GitHub workflow.Fixes
(which now cause a workflow failure thanks to ab32be1 & b793971).
asv_delegated_conda.py
plugin is the only reason we need specifiedconda_channels
(Performance Shift(s):bbb53585
#5280 (comment)), I decided it was more appropriate / less misleading to hard-code the Conda channel into the plugin script itself.Consult Iris pull request check list