Shapefile user guide typos #5759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5759 +/- ##
=======================================
Coverage 89.76% 89.77%
=======================================
Files 93 93
Lines 22982 22995 +13
Branches 5006 5011 +5
=======================================
+ Hits 20630 20643 +13
Misses 1622 1622
Partials 730 730 ☔ View full report in Codecov by Sentry. |
bjlittle
requested changes
Apr 4, 2024
There was a problem hiding this comment.
@acchamber Lovely update, thanks 💯
Just some minor suggestions to service, then we can bank this 🍻
|
|
still needs links to be added Co-authored-by: Bill Little <bill.little@metoffice.gov.uk>
|
Thanks for the review Bill, made the requested changes and added the extra links. |
bjlittle
approved these changes
Apr 15, 2024
|
Awesome, thanks @acchamber 🍻 |
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Apr 18, 2024
* upstream/main: Enhance Cube slicing docs (SciTools#5735) Bump scitools/workflows from 2024.04.0 to 2024.04.1 (SciTools#5914) [pre-commit.ci] pre-commit autoupdate (SciTools#5913) Revert "Updated environment lockfiles (SciTools#5911)" (SciTools#5912) Shapefile user guide typos (SciTools#5759) Updated environment lockfiles (SciTools#5911)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Fixed some typos, prettied some formatting, and cleaned up some of the wording in the userguide for shapefiles