Remove fill-value checks from netcdf saver. #5833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5833 +/- ##
==========================================
- Coverage 89.74% 89.73% -0.02%
==========================================
Files 92 92
Lines 22942 22898 -44
Branches 5464 5453 -11
==========================================
- Hits 20590 20547 -43
Misses 1620 1620
+ Partials 732 731 -1 ☔ View full report in Codecov by Sentry. |
|
Oh snap that's a full set of passing tests 😻 |
trexfeathers
added
the
benchmark_this
⏱️ Performance Benchmark Report: 4bac25aPerformance shiftsFull benchmark resultsGenerated by GHA run |
|
OK I've read through in detail and tested it myself. As far as I'm concerned this is ready to go. I accept that we would have liked to include some benchmarking to prove it but I suggest that comes in a second pull request IF we have the time before 3.9 is due. |
bjlittle
requested changes
Mar 27, 2024
There was a problem hiding this comment.
@trexfeathers Looks good to me.
A couple of minor comments to service, then we can bank this 👍
…to lazystream_fix_5_nofvcheck
This was referenced Mar 28, 2024
bjlittle
approved these changes
Apr 2, 2024
|
Thanks @bjlittle! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP trial for simply removing the fill-value checking
N.B. some tests will now fail ... to be dealt with laterPros+cons
da.store, which is officially recognised as having a memory-saving purpose "It stores values chunk by chunk so that it does not have to fill up memory"