Enable type hint checking #5956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5956 +/- ##
==========================================
+ Coverage 89.76% 89.77% +0.01%
==========================================
Files 90 90
Lines 22969 22984 +15
Branches 5029 5031 +2
==========================================
+ Hits 20618 20634 +16
+ Misses 1620 1619 -1
Partials 731 731 ☔ View full report in Codecov by Sentry. |
trexfeathers
requested changes
Jun 25, 2024
There was a problem hiding this comment.
Massive ❤ for tackling this @bouweandela.
I have some comments for you, and I don't know if @stephenworsley might be half-way through a review?
Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>
Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>
trexfeathers
approved these changes
Jun 26, 2024
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Jul 18, 2024
* upstream/main: Quieter datum warning (SciTools#6050) Allow MeshCoord to have a coord-system (SciTools#6016) Bump scitools/workflows from 2024.07.1 to 2024.07.2 (SciTools#6053) Faster concatenation of cubes with `AuxCoordFactory`s (SciTools#6038) Shorten cube iterator tests (SciTools#6041) Bump scitools/workflows from 2024.07.0 to 2024.07.1 (SciTools#6045) Bump scitools/workflows from 2024.06.5 to 2024.07.0 (SciTools#6034) Update test_Saver__ugrid.py (SciTools#6017) NEP29 and NumPy v2 pins (SciTools#6039) Adapt setup.py for pypa/setuptools@2db55275f. (SciTools#6036) Replace DelegatedConda with Delegated (SciTools#5963) Enable type hint checking (SciTools#5956) Bump scitools/workflows from 2024.06.4 to 2024.06.5 (SciTools#6026) Do not realize cell measures and ancillary variables in concatenate (SciTools#6010) [pre-commit.ci] pre-commit autoupdate (SciTools#6022) Bump scitools/workflows from 2024.06.3 to 2024.06.4 (SciTools#6018)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Enable mypy checks and fix issues with current type hints.
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: